Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

update nobooks #9

Merged
merged 24 commits into from
Jan 29, 2021
Merged

update nobooks #9

merged 24 commits into from
Jan 29, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jan 29, 2021 •
edited
Loading

What does this PR do?

This PR updates notebooks:

  • Add Colab Link
  • Add Introduction to notebook
  • 1 cell for each code block
  • 1 comment every cell
  • Add install
  • Add greetings
  • In predict, add link to fine-tune colab
  • Added to CHANGELOG

Here is how it looks.

Screenshot 2021-01-29 at 09 37 46

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@tchaton tchaton self-assigned this Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021 •
edited
Loading

Codecov Report

Merging #9 (076c06e) into master (e15745e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          28       28           
  Lines         859      859           
=======================================
  Hits          748      748           
  Misses        111      111
Flag Coverage Δ
unittests 87.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/classification/data.py 77.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15745e...e55d35f. Read the comment docs.

@Borda
Copy link
Member

Borda commented Jan 29, 2021

how is it related to #3?

@teddykoker
Copy link
Contributor

Think we should add treon back here: https://github.com/PyTorchLightning/lightning-flash/blob/update_notebooks/.github/workflows/ci-notebook.yml#L49-L52 (no need to run pytest on the notebooks/ directory, we have the e2e tests now)

@tchaton tchaton requested a review from carmocca as a code owner January 29, 2021 17:27
@pep8speaks
Copy link

pep8speaks commented Jan 29, 2021 •
edited
Loading

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-29 21:20:47 UTC

@tchaton tchaton merged commit 18c5917 into master Jan 29, 2021
@tchaton tchaton deleted the update_notebooks branch January 29, 2021 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edenlightning edenlightning edenlightning left review comments

@teddykoker teddykoker teddykoker approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees

@tchaton tchaton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tchaton @Borda @teddykoker @pep8speaks @edenlightning